HITL - Add object visbility handling and hide "self" in viewports. #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
aclegg3
approved these changes
May 17, 2024
0mdc
force-pushed
the
0mdc/object_visiblity
branch
from
918e086 to
6ea0ad7
Compare
0mdc
added a commit
that referenced
this pull request
May 23, 2024
…1959) * Add object visiblity and viewport visbility layers. * Hide self in viewports. * Don't render viewports if networking is disabled.
5 tasks
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jun 26, 2024
…acebookresearch#1959) * Add object visiblity and viewport visbility layers. * Hide self in viewports. * Don't render viewports if networking is disabled.
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
…acebookresearch#1959) * Add object visiblity and viewport visbility layers. * Hide self in viewports. * Don't render viewports if networking is disabled.
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
…acebookresearch#1959) * Add object visiblity and viewport visbility layers. * Hide self in viewports. * Don't render viewports if networking is disabled.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This leverages instance metadata keyframes to hide objects in viewports.
It introduces the concept of "visibility layers".
This also changes
rearrange_v2such as the user's agent is hidden from the first person view.Notes
Depends on:
habitat-simAgents are now transparent to selection, so they won't be interfering with UI flow:
Examples
Before:
viewports-2024-05-15_10.21.58.mp4
After:
object_properties-2024-05-15_10.45.29.mp4
How Has This Been Tested
Tested on multiplayer HITL.
Types of changes
Checklist