Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROCm support for bfloat16 #4039

Closed
wants to merge 3 commits into from

Conversation

ItsPitt
Copy link
Contributor

@ItsPitt ItsPitt commented Nov 21, 2024

Updated the hipify script to handle bfloat16 conversion and unblocked disabling for ROCm.

@ItsPitt
Copy link
Contributor Author

ItsPitt commented Nov 22, 2024

Is the windows build working correctly? It seems to be failing somewhere in setup.

@asadoughi
Copy link
Contributor

Is the windows build working correctly? It seems to be failing somewhere in setup.

Yes, there's a bug in the latest conda-build: addressing in #4040

@facebook-github-bot
Copy link
Contributor

@asadoughi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@asadoughi merged this pull request in 37f52dc.

@ItsPitt ItsPitt deleted the bfloat16_ROCm_support branch November 25, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants