Add explicit instanciations of search_dispatch_implem
#3860
Conversation
Since commit 32f0e8c (facebookresearch#3190) faiss fails to build on gcc7. For some reason gcc7 needs these explicit instanciations (or rather, for some reason later versions are OK without them). This commit partially revers that commit, adding back the explicit instanciations.
|
Hi @JAicewizard! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@JAicewizard Could you please share your use case, because gcc7 is quite old? Thanks. |
|
GCC7 might be quite old, however build systems that target old versions of glibc often use very old compilers. Many build environments that support old systems are also build on old systems, one I am working with still uses GCC4 (although it should be updated soon). Previous versions of faiss worked on GCC4 even (maybe even earlier, but that is the latest I tested). Since this is just a small change without a big maintenance burden, I hope it would be accepted. |
|
Agreed. We should accommodate as old compilers as possible. |
|
@mnorris11 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@mnorris11 merged this pull request in 6da9952. |
Summary: GCC7 doesnt support all the necessary NEON intrinsics, which is really a shame. However this means that for aarch64 GCC cannot compile faiss with neon intrinsics, so we should avoid using them. This is similar to #3860, build issues on GCC7, which I need. This one is a bit uglier, since GCC7 does support NEON just not all of the intrinsics. Pull Request resolved: #3869 Reviewed By: asadoughi Differential Revision: D63081962 Pulled By: junjieqi fbshipit-source-id: 69827cd447dd405b3ef70d651996f9ad00b6213e
…arch#3860) Summary: Since commit 32f0e8c (facebookresearch#3190) faiss fails to build on gcc7. For some reason gcc7 needs these explicit instanciations (or rather, for some reason later versions are OK without them). This commit partially revers that commit, adding back the explicit instanciations. Pull Request resolved: facebookresearch#3860 Reviewed By: mengdilin Differential Revision: D62762224 Pulled By: mnorris11 fbshipit-source-id: 938d5bc1917ef947847b1d8fcc3e40cea52e8367
Summary: GCC7 doesnt support all the necessary NEON intrinsics, which is really a shame. However this means that for aarch64 GCC cannot compile faiss with neon intrinsics, so we should avoid using them. This is similar to facebookresearch#3860, build issues on GCC7, which I need. This one is a bit uglier, since GCC7 does support NEON just not all of the intrinsics. Pull Request resolved: facebookresearch#3869 Reviewed By: asadoughi Differential Revision: D63081962 Pulled By: junjieqi fbshipit-source-id: 69827cd447dd405b3ef70d651996f9ad00b6213e
Since commit 32f0e8c (#3190) faiss fails to build on gcc7.
For some reason gcc7 needs these explicit instanciations (or rather, for some reason later versions are OK without them). This commit partially revers that commit, adding back the explicit instanciations.