Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Compress CUDA device code in libfaiss.so #2091

Closed

Conversation

trxcllnt
Copy link
Contributor

Pass -Xfatbin=-compress-all to nvcc so device code is compressed when embedded in libfaiss.so.

In our testing[1][2], compressing device code has negligible (or no) impact on compile, load, or run times, but significantly reduces the library size on disk:

# cmake -GNinja -B build -S . \
#  -DBUILD_SHARED_LIBS=ON -DBUILD_TESTING=OFF \
#  -DFAISS_ENABLE_GPU=ON -DFAISS_ENABLE_PYTHON=OFF \
#  -DCMAKE_CUDA_ARCHITECTURES="60-real;70-real;75-real;80-real;86"

# v1.7.0:
$ du -Shc build/faiss/libfaiss.so 
318M	build/faiss/libfaiss.so

# this PR:
$ du -Shc build/faiss/libfaiss.so 
160M	build/faiss/libfaiss.so

@facebook-github-bot
Copy link
Contributor

Hi @trxcllnt!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

1 similar comment
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot
Copy link
Contributor

@wickedfoo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@wickedfoo merged this pull request in fbf6b4a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants