Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use setuptools to install Python package #16

Closed
brunodoamaral opened this issue Mar 3, 2017 · 3 comments
Closed

Use setuptools to install Python package #16

brunodoamaral opened this issue Mar 3, 2017 · 3 comments
Labels

Comments

@brunodoamaral
Copy link
Contributor

I think the lib should have a setup.py install script, so one can easily install it with python setup.py install. What do you think?

I created a first version in this branch: https://github.com/brunodoamaral/faiss/tree/setup-py

The only problem is that I build the .so file using make, instead of creating an Extension on setup.py (I tried it before, but couldn't get makefile.inc parameters to work inside setuptools).

@mdouze mdouze added the wontfix label Mar 3, 2017
@mdouze
Copy link
Contributor

mdouze commented Mar 3, 2017

Thanks for the suggestion.

I don't think the setup.py simplifies the compilation process, since BLAS and swig are the hardest flags to set, not the Python flags.

@mdouze mdouze closed this as completed Mar 3, 2017
@brunodoamaral
Copy link
Contributor Author

Hi @mdouze. The idea behind using setuptools is to provide means to install faiss as a module on a Python environment. In the current implementation, one has to copy the lib files inside its project.

I think setuptools is an important step to distribute faiss (the next one should pip instal faiss). But if you think it is not necessary, I'll abandon the idea.

PS: I already deployed faiss in my current project and it searches a 670K x 128 database in less then 1.2ms, using a 4 CPU machine. Pretty neat for my needs.

@anxingle
Copy link

@brunodoamaral Good work!

mqnfred pushed a commit to mqnfred/faiss that referenced this issue Oct 23, 2023
….7.0

Update low level bindings for faiss v1.7.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants