Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep task level checkpoint key name generic #5330

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Keep task level checkpoint key name generic #5330

merged 2 commits into from
Sep 15, 2023

Conversation

piyush-kansal
Copy link
Contributor

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

In #5328, we introduced the logic of saving task level checkpoints. However, the task name was naively set to supernet. This PR fixes this issue by leveraging task's class name instead.

PR review

@cbalioglu

Did you have fun?

Make sure you had fun coding 🙃

@piyush-kansal piyush-kansal self-assigned this Sep 15, 2023
@piyush-kansal piyush-kansal marked this pull request as ready for review September 15, 2023 22:25
@piyush-kansal piyush-kansal removed the request for review from cbalioglu September 15, 2023 22:30
@cbalioglu cbalioglu merged commit 7409af7 into main Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbalioglu cbalioglu cbalioglu approved these changes

Assignees

@piyush-kansal piyush-kansal

Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piyush-kansal @cbalioglu @facebook-github-bot