Address comments

facebookresearch · Jun 15, 2022 · eeff5f2 · eeff5f2
1 parent 2b1c1a5
commit eeff5f2
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/detectron2/export/c10.py b/detectron2/export/c10.py
@@ -74,7 +74,9 @@ def has(self, name):
         return name in self.batch_extra_fields
 
     def set(self, name, value):
-        # len(tensor) leads to constants during tracing mode
+        # len(tensor) is a bad practice that generates ONNX constants during tracing.
+        # Although not a problem for the `assert` statement below, torch ONNX exporter
+        # still raises a misleading warning as it does not this call comes from `assert`
         if isinstance(value, Boxes):
             data_len = value.tensor.shape[0]
         elif isinstance(value, torch.Tensor):