This repository has been archived by the owner on Dec 18, 2023. It is now read-only.
Temporarily disable NNC-compile by default to enable PyTorch 2.0 #1836
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I hate to do this, but it looks like the compiler upgrade in PyTorch 2.0 somehow broke the pre-existing NNC usage in Bean Machine. Therefore, the algorithms that have NNC enabled by default are no longer working once we upgrade to PyTorch 2.0.
Until we figure out what's going on with the compiler, let's turn off NNC by default so that our tests can pass under PyTorch 2.0.
Changes proposed
setup.py
so we don't block downstream libraries that depend on us from using newer version of PyTorch.Test Plan
If CI pass then we should be good.
Types of changes
Checklist