Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Fix duplicate results when doing prediction #281

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Microsheep
Copy link

Fixes: #280

This fixes the problem with duplicate results when doing prediction due to loadBaseDocs been called twice. Once in initFromSavedModel and once in loadBaseDocs. This will generate duplicate entries in baseDocVectors_ which will be a problem in predictOne

@facebook-github-bot
Copy link

Hi @Microsheep!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Microsheep Microsheep changed the title Fix duplicate results when doing predict Fix duplicate results when doing prediction Feb 17, 2020
@everdark
Copy link

everdark commented Jul 25, 2020

I think the fix is not working due to initFromSavedModel still being called twice.
Instead of removing the loadBaseDocs call from query_predict, we should remove the call in initFromSavedModel.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate Results When Predict for Classification
3 participants