Adding gold units and functionality #923
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Based on the internal demo we ran today, I needed to make a few changes for gold units to work with our default setups out-of-box. This PR adds this, alongside a fix for unbounded gold launches (that we already had for validation).
Implementation
StaticBlueprint
andRemoteBlueprint
. These are mutually exclusive and warn when trying to use bothmax_gold_units
, which is the maximum number to be launched for a specific job. This follows through toget_gold_unit_data_for_worker
which will stop returning golds if they are no longer available, andshould_produce_gold_for_worker
which will no longer request golds for already-approved workers when golds are no longer available.Testing
Automated tests
Running during the demo today