Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extending some 1.1 changes #922

Merged
merged 2 commits into from
Oct 28, 2022
Merged

Extending some 1.1 changes #922

merged 2 commits into from
Oct 28, 2022

Conversation

JackUrb
Copy link
Contributor

@JackUrb JackUrb commented Oct 28, 2022

Overview

Two changes for the 1.1 release weren't pushed to their full extent. This PR resolves these.

Details

  • Pushes the Poetry installation changes made after switching to 1.2 that were added to the docs test to the actual deploy rule
  • Pushes the change for ensuring that returned Units on MTurk move to the correct disconnected state to OnboardingAgents instead of just regular Agents

Testing

Automated testing should suffice here.

@JackUrb JackUrb requested a review from pringshia October 28, 2022 17:04
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 28, 2022
@JackUrb JackUrb merged commit 66be164 into main Oct 28, 2022
@JackUrb JackUrb deleted the small-fixes branch October 28, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pringshia pringshia Awaiting requested review from pringshia

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JackUrb @facebook-github-bot