Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creates a readme for simple_static_task #882

Merged
merged 5 commits into from
Aug 8, 2022
Merged

Creates a readme for simple_static_task #882

merged 5 commits into from
Aug 8, 2022

Conversation

Etesam913
Copy link
Contributor

@Etesam913 Etesam913 commented Aug 3, 2022 •
edited
Loading

Overview

  • Creates a readme for simple_static_task
  • Updates StaticHTMLBlueprint readme to include information on the useMephistoGlobalConfig hook.

TODO:

  • I am trying to make it so that commits to only markdown files do not trigger the cypress e2e github action. Doesn't seem to be working currently.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 3, 2022
@Etesam913 Etesam913 requested a review from pringshia August 3, 2022 20:03
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2022 •
edited
Loading

Codecov Report

Merging #882 (40a3b7e) into main (1470dd5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #882   +/-   ##
=======================================
  Coverage   64.61%   64.61%           
=======================================
  Files         108      108           
  Lines        9313     9313           
=======================================
  Hits         6018     6018           
  Misses       3295     3295

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

pringshia
pringshia reviewed Aug 3, 2022
View reviewed changes
mephisto/abstractions/blueprints/static_html_task/README.md Outdated

```html
<script>
window._MEPHISTO_CONFIG.set(eventName, valueThatStateWillBeUpdatedTo)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eventName -> configName

pringshia
pringshia approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@pringshia pringshia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one update - otherwise looks great!

@Etesam913 Etesam913 merged commit b165bb2 into main Aug 8, 2022
@Etesam913 Etesam913 deleted the make-simple-static-task-readme branch August 8, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pringshia pringshia pringshia approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Etesam913 @codecov-commenter @pringshia @facebook-github-bot