-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ParlAI Assignment Fixes pt 2 #878
Conversation
Codecov Report
@@ Coverage Diff @@
## main #878 +/- ##
==========================================
+ Coverage 64.45% 64.49% +0.04%
==========================================
Files 108 108
Lines 9311 9312 +1
==========================================
+ Hits 6001 6006 +5
+ Misses 3310 3306 -4
Continue to review full report at Codecov.
|
return # need to wait for all agents to be here to launch | ||
|
||
for queried_agent in agents: | ||
if queried_agent.get_status() != AgentState.STATUS_WAITING: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Under what condition would this not be true? When things haven't synced to the worker threads?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When two workers connect at the same time, and both have had an _assign_unit_to_agent
thread called, and have thus both had Agent
s created, but only one of those threads has made it to the update_status
call.
Following #875, there's now the condition where too many assignments are being launched. While usually harmless to have this redundancy, it introduced a new race conditions where two threads could be launched for a single assignment. Having two assignment threads for the same assignment, being not ideal, is now patched.
Also bumps hydra in-line with the new expectations as of #869.