Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update searchbar colors #863

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Update searchbar colors #863

merged 2 commits into from
Jul 26, 2022

Conversation

Etesam913
Copy link
Contributor

@Etesam913 Etesam913 commented Jul 26, 2022

Overview

  • Made the algolia search conform to the Mephisto theme
  • Fixed issue with contextualSearch making the search bar at the search route not getting any results.
    • I had to delete the search index in the algolia search dashboard.
    • Then I had to crawl the webpage in the algolia crawler(this also recreates the index)
    • I don't know why this decided to work today, given that I tried these two steps multiple times yesterday, but 🤷‍♂️
  • Fixed resizing issue with algolia search
    • On the main page there is this bug:

    • resize-bug.mov
    • This has to do with the fact that the mobile version of the search modal has position: absolute instead of position: fixed for some reason

      • More specifically, the mobile version of the search modal does not account for the user scrolling the page
    • This seems to be a widespread issue as other documentation pages have not included this fix.

      • This is the published docusaurus page as of now:

      • docusaurus.mov

Video

new-search.mov

Resolves #862

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 26, 2022
@Etesam913 Etesam913 requested review from pringshia and JackUrb July 26, 2022 18:03
@Etesam913
Copy link
Contributor Author

I made an issue for the docusaurus people: facebook/docusaurus#7831

@pringshia
Copy link
Contributor

Nice, the color changes look great!

Hmm docusuarus page seems to work fine for me on Chrome 103? Perhaps it's a firefox issue?

@Etesam913
Copy link
Contributor Author

I was able to reproduce it in chrome. It has to do with switching from larger to smaller

in-chrome.mov

@Etesam913 Etesam913 merged commit c780e4a into main Jul 26, 2022
@Etesam913 Etesam913 deleted the update-searchbar-colors branch July 29, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Searchbar on https://mephisto.ai/search/ is broken
3 participants