Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heroku architect: fix default git branch name #824

Merged
merged 3 commits into from
Jul 15, 2022
Merged

heroku architect: fix default git branch name #824

merged 3 commits into from
Jul 15, 2022

Conversation

thammegowda
Copy link
Contributor

Closes #823

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 14, 2022
@JackUrb JackUrb self-requested a review July 15, 2022 18:10
@JackUrb
Copy link
Contributor

JackUrb commented Jul 15, 2022

Hi @thammegowda, thanks for identifying and resolving this issue! Rather than forcing the master name though, could we force main and then also update the architect to reflect this decision?

@thammegowda
Copy link
Contributor Author

welcome!
I thought of forcing main but I was not so sure if heroku supports deployment from main. I just found that it does!

So yes, we can force main instead of master. I will update the PR

Copy link
Contributor

@JackUrb JackUrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing this issue!

@JackUrb
Copy link
Contributor

JackUrb commented Jul 15, 2022

Ah also could you resolve the black issues? I'll merge this in right after!

@thammegowda
Copy link
Contributor Author

@JackUrb I tried fixing the issue. Please run the checks and let me know if it had fixed.
I havent used black before and if my recent commit hasn't fixed it, then give me a little bit more info about what the error is. Thanks!

@JackUrb
Copy link
Contributor

JackUrb commented Jul 15, 2022

Generally we manage running black through pre-commit. It's easy setup in case you choose to contribute in the future!

@JackUrb JackUrb merged commit 284b872 into facebookresearch:main Jul 15, 2022
@thammegowda thammegowda deleted the patch-1 branch July 15, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heroku deployment fails if the default git branch is not "master"
3 participants