Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cli for other mephisto commands #822

Merged
merged 10 commits into from
Jul 19, 2022

Conversation

Etesam913
Copy link
Contributor

@Etesam913 Etesam913 commented Jul 12, 2022

Just building off of #820

Moves away from the tabulate method in favor of the Table import in rich.

mephisto requesters

mephisto-requesters

mephisto register

mephisto-register

Added red color & provided list of valid providers in case the user forgot

mephisto register <provider_name>

mephisto-register-provider-name

mephisto metrics

mephisto-metrics

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 12, 2022
♻️ Removed unused imports & added colors to success/error messages
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2022

Codecov Report

Merging #822 (cabe3c6) into improve-cli-for-mephisto-wut (205bfe1) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@                       Coverage Diff                        @@
##           improve-cli-for-mephisto-wut     #822      +/-   ##
================================================================
- Coverage                         64.66%   64.61%   -0.06%     
================================================================
  Files                               107      107              
  Lines                              9281     9281              
================================================================
- Hits                               6002     5997       -5     
- Misses                             3279     3284       +5     
Impacted Files Coverage Δ
mephisto/data_model/assignment.py 57.81% <0.00%> (-3.91%) ⬇️
mephisto/data_model/unit.py 78.14% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 205bfe1...cabe3c6. Read the comment docs.

Copy link
Contributor

@JackUrb JackUrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for these QoL improvements across the codebase!

Base automatically changed from improve-cli-for-mephisto-wut to main July 19, 2022 19:43
@Etesam913 Etesam913 merged commit 1f5c88c into main Jul 19, 2022
@Etesam913 Etesam913 deleted the improve-cli-for-other-mephisto-commands branch July 29, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants