-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a tips example #791
Merged
Merged
Adds a tips example #791
Changes from 107 commits
Commits
Show all changes
108 commits
Select commit
Hold shift + click to select a range
cf68dcc
✨ Added get_tip_by_task_name & new_tip method
Etesam913 c9d9aff
✨ Added get_tip() method
Etesam913 1b0c7ea
🎨 Added Tip class to data_models folder
Etesam913 40f683b
✅ Added test_tips_methods() to test new db methods
Etesam913 7a80d98
🔥 Removed commented out code
Etesam913 39acef7
✨ Tips from webapp can now be read from backend
Etesam913 f6e9744
✨ Added update_current_agent_state_metadata()
Etesam913 bcef575
🚧 Tips from units of task are printed to user
Etesam913 586e824
✨ Created script for accepting/rejecting tips
Etesam913 d2d7468
✨ Added remove_accepted_tip script
Etesam913 8a0048e
🐛 MockAgentState now has update_metadata() function
Etesam913 bc515a1
✨ Now a bonus can be paid to a worker for their tip
Etesam913 06e47d4
♻️ Replace quit() statements with while loops
Etesam913 4030473
♻️ Added spacing
Etesam913 de85e12
Merge branch 'add-tips-to-toxicity-detection' of https://github.com/f…
Etesam913 47c7bca
🔨 Configured mephisto-task with npm link
Etesam913 5e7d46b
🏗️ Began postTip() in mephisto-task and server.py
Etesam913 cc25c57
🎨 Tips to persist without remote_procedure
Etesam913 5011a35
🐛 Tips from unsubmitted tasks do not hide in review
Etesam913 e45e596
🔥 Removed tips db methods & data-model
Etesam913 0eb5146
♻️ Tip endpoints generalized into metadata endpoints
Etesam913 bbec236
🚨 Removed some extra spaces
Etesam913 ff4d52e
🐛 Fixed unrecognized tips in remove_tip script
Etesam913 90a07cb
✨ Tips can now be retrieved from taskConfig property
Etesam913 a6f5010
⛓ Linked mephisto-worker-experience to toxic example
Etesam913 686f954
Merge branch 'tips-component' of https://github.com/facebookresearch/…
Etesam913 9dbb1a5
➕ Added react-popper-tooltip lib for tooltips
Etesam913 67ef982
✨ Tips are now retrieved and submitted by default
Etesam913 1fb9059
✨ Added success/error handling for worker-experience
Etesam913 702a05c
♻️ Refactored Tips.js
Etesam913 88f4885
📝 Removed createTip & createFeedback exports
Etesam913 e6e75e1
✨ List prop is now used for default tips
Etesam913 e5f94f4
🐛 Fixed static-react-task not starting
Etesam913 e6cc801
✨ Added tips example
Etesam913 4bf8181
✅ Pass code-style test in Tips.js
Etesam913 846f69b
🚨 Mocked test_deploy_shutdown input
Etesam913 6eae9bb
🚨 Relinted code
Etesam913 fecb3e3
📝 Updated readmes of a task and package
Etesam913 2d7a637
🔀 Merged with tips-component
Etesam913 4f659e5
✏️ Fixed typos and added more detail to mep-task readme
Etesam913 5c709ab
🧪 Trying out moving db code out of build_router
Etesam913 29cb77c
🚚 Moved build_router db code to frontend_args
Etesam913 500b0d8
🔀 Merged with tips-component branch
Etesam913 05bb004
🐛 Fixed bug with text str failing check
Etesam913 6a8f43e
🐛 Fix bug with feedback text not a string
Etesam913 5dee9f7
✨ Added suppport for metadata in chat task
Etesam913 536e789
🔥 Removed None if statement for metadata
Etesam913 e155acd
🔥 Removed undeeded packages from toxicity_detection
Etesam913 208a307
✨ Added mpackage to yarn workspaces
Etesam913 4602ba3
↩️ Reverted the mephisto-task version increment
Etesam913 b959010
✅ Passed code-style test
Etesam913 ba231fd
♻️ Refactored get_frontend_args to make code common
Etesam913 46065b5
✨ Ttextnow shown as wrapped when enter is pressed
Etesam913 fec8427
🎨 Added maxHeight for tips list
Etesam913 59dc6a7
🎨 Changed position of the tips button
Etesam913 1995403
✅ Reformat tips
Etesam913 cd73e77
🔥 Removed extra space
Etesam913 99c2602
🔀 Merged with add-cypress-to-static-task
Etesam913 df705a9
🎨 Updated the headless version of Tips
Etesam913 1f575b6
🎨 Prefixed tips classnames to improve readability
Etesam913 851cba1
✏️ Renamed worker-experience to worker-addons
Etesam913 6893718
🚛 Moved databrowser out of base blueprint class
Etesam913 a26fdb4
✏️ Fixed typo with mephisto-user-experience
Etesam913 237d6b3
🎨 Changed loader className to prevent clashes
Etesam913 a677c80
🐛 Fixed bug where button was loading forever
Etesam913 ad1c5d7
🎨 Split main tips file into two more components
Etesam913 255ac13
🚛 Moved tipsComponents into TaskTips file
Etesam913 8841f0c
✅ Updated formatting
Etesam913 5c01b86
🎨 Modified fonts & sizes for tips popup
Etesam913 e455f7c
🔥 Removed some unneeded testing code
Etesam913 155282c
✨ Added a close button for the tips popup
Etesam913 7dd6206
🔥 Replaced bulma.css with custom styles
Etesam913 194942c
✏️ Removed headless prop
Etesam913 2ed447e
🎨 Upped line-height and added box-sizing property
Etesam913 046dfe9
🎨 Made small style changes to Tips
Etesam913 9e8b96c
🚛 Moved tips button in example
Etesam913 22bd57b
🎨 Small style fixes
Etesam913 6d76b13
✏️ Added margin to tip_text
Etesam913 d2e35b3
🚛 Moved tips logic in clientIO to agent
Etesam913 96a9d6a
Merge branch 'add-cypress-to-static-task' of https://github.com/faceb…
Etesam913 e532205
♻️ Added hydra params to build_bundle in new example
Etesam913 7a9ebee
🔀 Merge branch 'add-cypress-to-static-task'
Etesam913 bbbf29a
🔀 Merged with agent-state-consolidate
Etesam913 49d28a5
🏗 Began working on refactor
Etesam913 0b02403
✨ Refactored tips works witth remote-tasks
Etesam913 783529d
🗑 Cleaned up most files
Etesam913 256aa79
👈 Reverted _update_submit()
Etesam913 887c3d5
☝️ Switched order of load_metadata() and load_data()
Etesam913 1189241
Merge branch 'main' of https://github.com/facebookresearch/Mephisto i…
Etesam913 048f0b3
Merge branch 'main' into add-tips-example
Etesam913 11a3442
Merge branch 'add-tips-example' of https://github.com/facebookresearc…
Etesam913 0c6cd87
🐛 Added an import that was removed previously
Etesam913 f56079e
🐛 Made UserSubmission inputs disabled when loading
Etesam913 070a7c1
🔥 Removed comment & unused import
Etesam913 5824274
🔧 Configured react-shadow with Tips component
Etesam913 b383d54
👈 Reverted tips-example styles back to default
Etesam913 b0a3874
✨ Tips is in shadow dom when headless=false
Etesam913 eed4376
✏️ Fixed typo with headless=true being default
Etesam913 aeee926
♻️ Refactored unit collection
Etesam913 1dca1d3
✨ Tips are now saved to a tips.csv file
Etesam913 a53de6f
♻️ Moved metadata gathering in base blueprint class
Etesam913 0b8c9cf
♻✅ Added required fields to tips_location field
Etesam913 862e9f4
✅ Set default of tips_location to MISSING
Etesam913 d6a63f1
🥅 Added error check for get_tips_directory()
Etesam913 dba55fe
♻️ Added a more sensible default for tips_location
Etesam913 fc37242
🚛 Moved tips_location to base BlueprintArgs
Etesam913 ebfde86
🐛 Fixed issue with tips_location default
Etesam913 cee4929
🔥 Removed self.task_run from blueprint.py
Etesam913 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! Thanks for the refactor.