-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input hides when annotation is correct for mnist example #782
Conversation
Am I not supposed to commit the package-lock.json because for some reason that seems to be adding many additions. I'm not sure why it's changing so much? |
The changes seem pretty uneventful, mostly just dropping the The easy fix here, since you're not actually installing any new packages, is to just git revert the For the longer term though, what npm version are you using? For me it's:
|
I'll do |
One thing I notice is that the package-lock.json seems to change when running |
Looks good to me! Thanks for the video in the PR description. I don't have a strong opinion on this either way, but another implementation we could add here is to reset the input box on toggling "Correct Annotation". However I'm not really sure if this UX change is worth the additional code. A more sensible/obvious enhancement though would be to reset the input box when a new number is drawn. In that case, having a transient value from a previous drawing makes little sense. That said, feel free to merge this in! |
Summary
In the mnist example clicking on the "Annotation Correct?" checkbox does not make it immediately clear to the user that they should type in the corrected annotation in the text input below.
This is fixed by only showing the "Corrected Annotation" text input when the "Annotation Correct?" checkbox is not ticked. When it is ticked, the text input is hidden.
Testing
task-1-vid.mov
From the video it should be easy to see that when the "Annotation Correct?" checkbox is ticked, the text input goes away.