-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EC2Architect fixed warning when domain is in use #618
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're still making a lot of unrelated formatting changes in ec2_helpers.py
- I don't think these are related to the given PR.
@JackUrb actually i am not ,I am still figuring out why that file is being formatted ,can you please suggest how to fix this formatting issue ,I have ran black also on both the ec2_helpers.py and ec2_architect.py file but still getting formatting issue on the PR. |
Well, for |
@JackUrb when i run black it shows |
What is the full command you are running? Ideally you should pip install |
@JackUrb I have fixed the formatting issues ,now their are no conflicts ,are there any additional changes that i need to do ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for going through the manual effort here @Yash621. I'd really like to help figure out why the automated tooling isn't working for you.
At the very least, running pre-commit run --all-files
should have been able to automatically run on your commit and made the changes, perhaps that's something to try next time?
In any case, thanks again for the contribution and for sticking this one out!
@JackUrb ,surely i will try that next time ! |
This PR is in respect to issue #614 and continuation of PR #617
@JackUrb please review it , I have done all the changes that you suggested .