EC2Architect - Various small improvements #609
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In more testing, ran into two primary issues:
tmux
sessions sometimes the ssh-agent forwarding would become stale and then setting up the server would hang indefinitely.Implementation
SSH_AUTH_SOCK
in the env overwrites use of the ssh-agent for auth (which we don't need as we're referring to the.pem
keypair anyways), which should resolvetmux
issues (can't directly reproduce yet).Owner
tag to all resources, to make them easier to trackcc @klshuster @ytsheng