Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mypy backlog cleanup #601

Merged
merged 3 commits into from
Nov 8, 2021
Merged

Mypy backlog cleanup #601

merged 3 commits into from
Nov 8, 2021

Conversation

JackUrb
Copy link
Contributor

@JackUrb JackUrb commented Nov 3, 2021

Overview

Running through all of the mypy issues, as an initial start to #598 and to close some of the nearby issues. Mostly involved just telling mypy what was really going on in certain places, but actually did clarify logic and catch a minor bug in onboarding initialization.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 3, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #601 (8c07bc6) into main (b009357) will decrease coverage by 0.17%.
The diff coverage is 55.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #601      +/-   ##
==========================================
- Coverage   66.46%   66.28%   -0.18%     
==========================================
  Files          82       83       +1     
  Lines        7562     7605      +43     
==========================================
+ Hits         5026     5041      +15     
- Misses       2536     2564      +28     
Impacted Files Coverage Δ
...ueprints/static_html_task/static_html_blueprint.py 41.79% <0.00%> (-1.96%) ⬇️
...prints/static_react_task/static_react_blueprint.py 56.52% <0.00%> (-3.95%) ⬇️
...isto/abstractions/providers/mock/mock_datastore.py 53.92% <ø> (-1.32%) ⬇️
...sto/abstractions/providers/mturk/mturk_provider.py 48.75% <0.00%> (ø)
...ephisto/abstractions/providers/mturk/mturk_unit.py 15.93% <0.00%> (-0.27%) ⬇️
...histo/abstractions/providers/mturk/mturk_worker.py 32.96% <0.00%> (ø)
mephisto/abstractions/test/utils.py 81.81% <ø> (ø)
mephisto/data_model/assignment.py 58.13% <0.00%> (-0.46%) ⬇️
mephisto/data_model/task.py 45.20% <0.00%> (-0.63%) ⬇️
mephisto/operations/utils.py 36.36% <ø> (+0.32%) ⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b009357...8c07bc6. Read the comment docs.

@pringshia
Copy link
Contributor

Nicely done

@JackUrb JackUrb merged commit 4937db1 into main Nov 8, 2021
@JackUrb JackUrb deleted the mypy-fixes-1 branch November 8, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants