Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ref based state-retrieval #570

Merged
merged 4 commits into from
Oct 4, 2021
Merged

Add support for ref based state-retrieval #570

merged 4 commits into from
Oct 4, 2021

Conversation

pringshia
Copy link
Contributor

@pringshia pringshia commented Sep 20, 2021

Closes #521

More details in the issue, but essentially global application state can now be retrieved imperatively via the container application using a ref. This should make integrations easier.

mp-gcs-ref-forwarding.mp4

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 20, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2021

Codecov Report

Merging #570 (6423cf4) into main (47c6fa5) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #570      +/-   ##
==========================================
+ Coverage   66.32%   66.34%   +0.02%     
==========================================
  Files          81       81              
  Lines        7459     7459              
==========================================
+ Hits         4947     4949       +2     
+ Misses       2512     2510       -2     
Impacted Files Coverage Δ
...tractions/architects/channels/websocket_channel.py 80.23% <0.00%> (-1.17%) ⬇️
mephisto/operations/supervisor.py 80.80% <0.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47c6fa5...6423cf4. Read the comment docs.

@pringshia pringshia changed the title [WIP] Add support for ref based state-retrieval Add support for ref based state-retrieval Sep 24, 2021
@pringshia pringshia requested review from JackUrb and s0mya September 24, 2021 22:06
@pringshia pringshia added the enhancement New feature or request label Sep 24, 2021
Copy link
Contributor

@JackUrb JackUrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for waiting for this review, needed to take a moment to grasp the semantics. Looks good though! Definitely will be helpful to pull the state out where necessary.

@pringshia pringshia merged commit 5579712 into main Oct 4, 2021
@pringshia pringshia deleted the gcs-retrieve branch October 4, 2021 20:58
@JackUrb JackUrb added this to the 🚀 Mephisto 1.0 milestone Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add on-demand state retrieval via a ref from global-context-store's <Store />
4 participants