Updating compatibility for Hydra 1.1 #494
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Hydra 1.1 introduces some breaking changes alongside really desired functionality, so this PR includes changes to get us up to the new standards.
Resolves #488
Details
Migrating config folders
By default, hydra used to use the local directory as the source for finding config paths. Now this behavior is deprecated, and we need to provide a source directory. As an upside, this also means we can eventually collect a repository of common configuration options in the future.
This updates all of the demos to pull from
hydra_configs
now.Migrating groups
Hydra used to configure groups with directive keywords, but now the default behavior for a package with a given name is to automatically expand
_group_._package_
, which means we can simply specify thename
andgroup
and not need to add thepackage
when we're registering a config.Default merging
By providing default values in the base
MephistoConfig
forblueprint
,provider
, andarchitect
, we were confusing Hydra's automated merging. These aren't really necessary, and so I've replaced withMISSING
.Testing
Ran all of the examples locally, ran unit testing.