Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating compatibility for Hydra 1.1 #494

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Updating compatibility for Hydra 1.1 #494

merged 1 commit into from
Jul 30, 2021

Conversation

JackUrb
Copy link
Contributor

@JackUrb JackUrb commented Jul 8, 2021

Overview

Hydra 1.1 introduces some breaking changes alongside really desired functionality, so this PR includes changes to get us up to the new standards.

Resolves #488

Details

Migrating config folders

By default, hydra used to use the local directory as the source for finding config paths. Now this behavior is deprecated, and we need to provide a source directory. As an upside, this also means we can eventually collect a repository of common configuration options in the future.

This updates all of the demos to pull from hydra_configs now.

Migrating groups

Hydra used to configure groups with directive keywords, but now the default behavior for a package with a given name is to automatically expand _group_._package_, which means we can simply specify the name and group and not need to add the package when we're registering a config.

Default merging

By providing default values in the base MephistoConfig for blueprint, provider, and architect, we were confusing Hydra's automated merging. These aren't really necessary, and so I've replaced with MISSING.

Testing

Ran all of the examples locally, ran unit testing.

@JackUrb JackUrb requested a review from pringshia July 8, 2021 15:26
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 8, 2021
@JackUrb JackUrb merged commit 4aff7a8 into master Jul 30, 2021
@JackUrb JackUrb deleted the hydra-1.1 branch July 30, 2021 20:19
@JackUrb JackUrb added this to the 🚀 Mephisto 1.0 milestone Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running static_test_script.py: Usage of deprecated keyword in package header
2 participants