Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further clarifying misleading heroku exception. #486

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Conversation

JackUrb
Copy link
Contributor

@JackUrb JackUrb commented Jun 28, 2021

As part of resolving heroku logging in #93, adds more context to the failure log to not lead people in the wrong direction.

As part of resolving heroku logging in #93, adds more context to the failure log to not lead people in the wrong direction.
@JackUrb JackUrb requested review from pringshia and jxmsML June 28, 2021 13:26
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 28, 2021
@pringshia
Copy link
Contributor

Should be serviceable as a temporary band-aid for now, with the intention of propagating through underlying exceptions/errors at some point in the future.

@JackUrb JackUrb merged commit 9341714 into master Jun 28, 2021
@JackUrb JackUrb deleted the heroku-log-patch branch June 28, 2021 14:26
@jxmsML
Copy link

jxmsML commented Jun 28, 2021

thanks for this quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants