Simple Supervisor shutdown array fix #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
JackUrb
changed the title
Codecov Report
@@ Coverage Diff @@
## master #443 +/- ##
=======================================
Coverage 66.05% 66.05%
=======================================
Files 78 78
Lines 7105 7106 +1
=======================================
+ Hits 4693 4694 +1
Misses 2412 2412
Continue to review full report at Codecov.
|
| @@ -211,7 +211,8 @@ def shutdown(self): | |||
| if self.sending_thread is not None: | |||
| self.sending_thread.join() | |||
| logger.debug(f"Joining agents {self.agents}") | |||
| for agent_info in self.agents.values(): | |||
| agents_to_close = list(self.agents.values()) | |||
There was a problem hiding this comment.
Could you add a comment explaining the reason for separating it like that here. If I am refactoring this code and I get to to this line, I definitely change it back to what it was before this PR.
mojtaba-komeili
approved these changes
Apr 27, 2021
mojtaba-komeili
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now shutdown isn't being particularly safe iterating over the agents to close. This updates that iteration to pre-populate the list of threads to join.