Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make expire fast for completed units #440

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Make expire fast for completed units #440

merged 1 commit into from
Apr 21, 2021

Conversation

bottler
Copy link
Contributor

@bottler bottler commented Apr 21, 2021

As I mentioned in #431, we don't need to contact boto to expire a hit if it is already expired or completed.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 21, 2021
JackUrb
JackUrb approved these changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@JackUrb JackUrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement @bottler!

@JackUrb JackUrb merged commit 87b96a0 into facebookresearch:master Apr 21, 2021
@bottler bottler deleted the fast_expire branch April 21, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackUrb JackUrb JackUrb approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bottler @JackUrb @facebook-github-bot