Adding config arguments to heroku architect #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Thanks for this PR! On high level LGTM. To make it work e2e we need some minor changes. Please see this PR: #413 |
…pp name (#413) * Specified heroku app name while setting config args * Fixed code style * Allow adding customized heroku app name in config * Fixed code style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In order to set configuration arguments for Heroku, there needs to be a way to specify them to be pushed from the CLI. This PR adds an argument for setting these to the structured config, and then parses it and writes it out. Implementation is pretty straightforward.
Testing:
I haven't tested extensively. @snyxan please try this out for your case!
Ran
With the contents I added to the readme, and this works.