Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how the ParlAI chat world is loaded throughout #319

Merged
merged 2 commits into from
Dec 1, 2020

Conversation

EricMichaelSmith
Copy link
Contributor

Apply the path fix in #302 to two other places in the code

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 1, 2020
@codecov-io
Copy link

Codecov Report

Merging #319 (581dea5) into master (c10cdc4) will decrease coverage by 0.16%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
- Coverage   66.16%   66.00%   -0.17%     
==========================================
  Files          76       76              
  Lines        6710     6710              
==========================================
- Hits         4440     4429      -11     
- Misses       2270     2281      +11     
Impacted Files Coverage Δ
...ns/blueprints/parlai_chat/parlai_chat_blueprint.py 41.12% <0.00%> (ø)
.../blueprints/parlai_chat/parlai_chat_task_runner.py 31.29% <0.00%> (ø)
...tractions/architects/channels/websocket_channel.py 79.06% <0.00%> (-3.49%) ⬇️
mephisto/data_model/packet.py 96.77% <0.00%> (-3.23%) ⬇️
mephisto/abstractions/architects/mock_architect.py 88.88% <0.00%> (-2.62%) ⬇️
mephisto/operations/supervisor.py 77.28% <0.00%> (-0.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c10cdc4...581dea5. Read the comment docs.

Copy link
Contributor

@JackUrb JackUrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, though the next improvement is likely going to be the ability to directly pass the module itself over via SharedTaskState, as was partially introduced here.

I note that the ParlAIChatTaskRunner is not actually prepared to load in a shared-state provided world module yet, so this doesn't need to happen immediately.

@EricMichaelSmith EricMichaelSmith merged commit 1fcc45d into master Dec 1, 2020
@EricMichaelSmith EricMichaelSmith deleted the change-other-world-loading branch December 1, 2020 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants