Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing agent desync on RemoteProcedure tasks #1063

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Conversation

JackUrb
Copy link
Contributor

@JackUrb JackUrb commented Sep 14, 2023

Small bugfix for Remote Procedure that prevents tasks from receiving an agentId before it has been fully initialized.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 14, 2023
@facebook-github-bot
Copy link
Contributor

Hi @JackUrb!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@meta-paul meta-paul force-pushed the v1.2-dev branch 2 times, most recently from 1f4fe78 to aba6369 Compare December 19, 2023 17:33
@meta-paul meta-paul force-pushed the fix-agent-id-desync branch from aa88b34 to 12b3bda Compare March 6, 2024 23:47
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 79.91498% with 189 lines in your changes are missing coverage. Please review.

Project coverage is 60.45%. Comparing base (aba6369) to head (6fef397).

Files Patch % Lines
mephisto/scripts/form_composer/rebuild_all_apps.py 22.61% 65 Missing ⚠️
mephisto/client/cli.py 40.62% 57 Missing ⚠️
...orm_composer/config_validation/task_data_config.py 89.74% 20 Missing ⚠️
...abstractions/providers/prolific/prolific_worker.py 10.00% 9 Missing ⚠️
...histo/abstractions/providers/mturk/mturk_worker.py 75.00% 6 Missing ⚠️
.../abstractions/providers/prolific/prolific_utils.py 25.00% 6 Missing ⚠️
...phisto/abstractions/architects/heroku_architect.py 0.00% 4 Missing ⚠️
...prints/static_react_task/static_react_blueprint.py 0.00% 3 Missing ⚠️
...ephisto/abstractions/providers/mock/mock_worker.py 75.00% 3 Missing ⚠️
...to/abstractions/providers/prolific/api/messages.py 25.00% 3 Missing ⚠️
... and 8 more
Additional details and impacted files
@@             Coverage Diff              @@
##           v1.2-dev    #1063      +/-   ##
============================================
- Coverage     62.71%   60.45%   -2.27%     
============================================
  Files           179      208      +29     
  Lines         12594    14625    +2031     
============================================
+ Hits           7898     8841     +943     
- Misses         4696     5784    +1088     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meta-paul meta-paul changed the base branch from v1.2-dev to main March 12, 2024 15:04
@meta-paul meta-paul merged commit afcfb9c into main Mar 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants