Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AWS credentials pre-commit hook #1018

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Conversation

meta-paul
Copy link
Contributor

Implementation of https://gist.github.com/czardoz/b8bb58ad10f4063209bd

Note that correct regexp for AWS keys should be taken from here https://github.com/awslabs/git-secrets

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 24, 2023
Copy link
Contributor

@JackUrb JackUrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for including

@meta-paul meta-paul force-pushed the aws-creds-precommit-hook branch from 842f879 to 1784c66 Compare April 24, 2023 16:05
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.11 🎉

Comparison is base (08b9900) 63.97% compared to head (1784c66) 64.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1018      +/-   ##
==========================================
+ Coverage   63.97%   64.09%   +0.11%     
==========================================
  Files         108      108              
  Lines        9450     9450              
==========================================
+ Hits         6046     6057      +11     
+ Misses       3404     3393      -11     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@meta-paul meta-paul merged commit 97e256f into main Apr 27, 2023
@JackUrb JackUrb deleted the aws-creds-precommit-hook branch September 14, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants