Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Prolific provider (#1008) #1012
Add Prolific provider (#1008) #1012
Changes from 44 commits
df0f514
383da82
87b37a3
7aa9fda
1574c70
beffb95
749b017
8429c44
d834ced
082d778
9c2b514
bc34b57
2718655
c984246
b734e8d
49d86cc
17ede4d
3aaa878
ac741cc
ac594c8
50faed5
b619d9f
d6d90da
a2bc750
328403c
58fc94b
2a0dba3
1e8e276
a386277
60990e0
dbd5b14
88ac0e9
3d13138
aea4e5c
242cca6
daf748a
b8d8b85
dd7a66d
be873d3
5114a06
03ab8fa
f6a28a4
e31e516
b207500
19a2354
50514ba
1807386
a971702
78ff3f5
5dc9c47
db3dd84
7d08666
c66b861
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a particular reason to have a separate data file for Prolific?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just wanted to have 1 study per paunch :) No problem, I'll remove it when code testing is finished
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, eventually we'll move this to an example provider config and put it in a guide - it probably won't remain a standard part of the
simple_static_task
especially given external folks aren't definitely using theec2
setup.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that this is all functional, I'm not sure what the correct thing for us to be doing to demonstrate different providers will be, but I don't think it's going to be to have a different script in here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that there are some Prolific-specific bits in there, like
default_config_file
andshared_state.prolific_specific_qualifications
(it was meant to show how to work with Prolific-specific integration)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, just I think we need to have another way to demonstrate provider use in a script, rather than leaving them in task examples (something like
examples/providers
which uses a simple task (ideally the React variant) and show it for multiple providers). We can commit here for now, but it's a TODO item.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As much as this appears an unnecessary import, the forced load of a
Blueprint
's module ensures that Mephisto is able to use that task. While we pre-load all of the Mephisto-standard blueprints, I've left this here to pre-empt the question when externally implemented blueprints aren't functioning for others.I definitely think there's room to improve the way the Mephisto registry works such that it isn't hinging on the side-effects of an import.