Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

__heroku_app_url empty when using heroku #1060

Closed
gaotianyu1350 opened this issue Sep 13, 2023 · 1 comment
Closed

__heroku_app_url empty when using heroku #1060

gaotianyu1350 opened this issue Sep 13, 2023 · 1 comment

Comments

@gaotianyu1350
Copy link

It seems that heroku changed their output and the current way of getting the URL with the hash will get an empty string.

The code at this line should be changed to

self.__heroku_app_url = domains.split("\n")[2]
JackUrb added a commit that referenced this issue Sep 13, 2023
@JackUrb
Update heroku_architect.py
dfe44cc 
Addressing #1060
@JackUrb JackUrb mentioned this issue Sep 13, 2023
Merged
@JackUrb
Copy link
Contributor

JackUrb commented Sep 13, 2023

Thanks for catching @gaotianyu1350, I have a patch up that should hopefully resolve this more robustly.

meta-paul added a commit that referenced this issue Oct 20, 2023
@JackUrb @meta-paul
Update heroku_architect.py (#1062)
9fb0dec 
* Update heroku_architect.py

Addressing #1060

* Fixed code styling

---------

Co-authored-by: Paul Abumov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JackUrb @gaotianyu1350 @meta-paul