Skip to content

Commit

Permalink
♻️ Added two argument overrides for architect
Browse files Browse the repository at this point in the history
  • Loading branch information
Etesam913 committed Jul 31, 2022
2 parents 8403096 + c97c7a3 commit a58678e
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 5 deletions.
4 changes: 2 additions & 2 deletions docs/web/docs/reference/Architects.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
|use_hobby|bool|False|Launch on the Heroku Hobby tier|None|False|
|heroku_team|unknown|???|Heroku team to use for this launch|None|False|
|heroku_app_name|unknown|???|Heroku app name to use for this launch|None|False|
|heroku_config_args|unknown|<dataclasses._MISSING_TYPE object at 0x103ecfac0>|str:str dict containing all heroku config variables to set for the app|None|False|
|heroku_config_args|unknown|{}|str:str dict containing all heroku config variables to set for the app|None|False|

## ec2

Expand All @@ -52,5 +52,5 @@
|server_type|str|node|None|None|False|
|server_source_path|str|???|Optional path to a prepared server directory containing everything needed to run a server of the given type. Overrides server type. |None|False|
|instance_type|str|t2.micro|Instance type to run router|None|False|
|subdomain|str|${mephisto.task.task_name}|Subdomain name for routing|None|False|
|subdomain|str|The task name defined in your task's hydra config|Subdomain name for routing|None|False|
|profile_name|str|???|Profile name for deploying an ec2 instance|None|False|
File renamed without changes.
6 changes: 5 additions & 1 deletion mephisto/client/cli_commands.py
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,11 @@ def get_wut_arguments(args):
return

# These are values that do not convert to a string well or are incorrect, so they need to be hardcoded
argument_overrides = {"tips_location": ("default", "path_to_task/assets/tips.csv")}
argument_overrides = {
"tips_location": ("default", "path_to_task/assets/tips.csv"),
"heroku_config_args": ("default", "{}"),
"subdomain": ("default", "The task name defined in your task's hydra config"),
}

arg_dict = get_extra_argument_dicts(target_class)[0]
click.echo(arg_dict["desc"])
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

def main():
architect_file = MdUtils(
file_name="../../../../docs/web/docs/reference/Architects.md",
file_name="../../../../docs/web/docs/reference/architects.md",
)
architect_file.new_header(level=1, title="Architects")
valid_architect_types = get_valid_architect_types()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def create_blueprint_info(blueprint_file, arg_dict):

def main():
blueprint_file = MdUtils(
file_name="../../../../docs/web/docs/reference/Blueprints.md",
file_name="../../../../docs/web/docs/reference/blueprints.md",
)
blueprint_file.new_header(level=1, title="Blueprints")
blueprint_file.new_paragraph("The blueprint determines the task content.")
Expand Down

0 comments on commit a58678e

Please sign in to comment.