Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BPE: bring data into imagebind library #119

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Fix BPE: bring data into imagebind library #119

merged 3 commits into from
Jul 10, 2024

Conversation

ChrisjanWust
Copy link
Collaborator

@ChrisjanWust ChrisjanWust commented Jul 10, 2024

Based on https://github.com/ericschreiber 's work on bringing the BPE data into the package: #112

I've added some commits to resolve merge conflicts / ignore quotation changes

From the original PR:

I (probably also others) just wanted to use this as a package. For the text embeddings to work, one needs to include the bpe tokenizer. This file was not included into the package.
This should be fixed and this package can be used out of different directories now with the standard package builds.

TL;DR: brings the BPE data into imagebind/ so that you don't have to copy that yourself manually when installing ImageBind as a library.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 10, 2024
@ChrisjanWust ChrisjanWust changed the title Bpefix Fix BPE: bring data into imagebind library Jul 10, 2024
@ChrisjanWust ChrisjanWust merged commit 3fcf5c9 into main Jul 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants