Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do you actually require pytest-runner during setup? #351

Closed
hmaarrfk opened this issue Feb 14, 2022 · 2 comments · May be fixed by #357
Closed

Do you actually require pytest-runner during setup? #351

hmaarrfk opened this issue Feb 14, 2022 · 2 comments · May be fixed by #357

Comments

@hmaarrfk
Copy link

CrypTen/setup.py

Line 54 in c6e8ebf

setup_requires=["pytest-runner"],

We are trying to add the package to conda and it seems weird to depend on pytest runner during the setup phase.

Is it actually a setup dependency?

If not, can we remove it from the setup dependencies and add it to the test dependencies?

Thank you!

Best,

Mark

conda-forge/staged-recipes#15720
@hmaarrfk hmaarrfk mentioned this issue Feb 14, 2022
Merged
9 tasks
@knottb
Copy link
Contributor

knottb commented Feb 22, 2022

I don't think we need this. I believe the setup.py file was written using setuptools, which seems to have deprecated this here: https://pypi.org/project/pytest-runner/

@hmaarrfk
Copy link
Author

Thank you for confirming. That was our understanding as well.

@knottb knottb closed this as completed Feb 24, 2022
@hmaarrfk hmaarrfk mentioned this issue Feb 24, 2022
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove pytest-runner as a dependency during setup. hmaarrfk/CrypTen
2 participants
@hmaarrfk @knottb