Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added recipe for crypten #15720

Merged
merged 22 commits into from
Feb 14, 2022
Merged

Added recipe for crypten #15720

merged 22 commits into from
Feb 14, 2022

Conversation

sarthakpati
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/crypten) and found some lint.

Here's what I've got...

For recipes/crypten:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/crypten) and found it was in an excellent condition.

@stale
Copy link

stale bot commented Feb 12, 2022

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

@stale stale bot added the stale will be closed in 30 days label Feb 12, 2022
@stale stale bot removed the stale will be closed in 30 days label Feb 12, 2022
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/crypten) and found some lint.

Here's what I've got...

For recipes/crypten:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/crypten) and found it was in an excellent condition.

@sarthakpati
Copy link
Contributor Author

Hi @conda-forge/python, @conda-forge/staged-recipes, this is ready for review!

Copy link
Contributor

@hmaarrfk hmaarrfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few cleanup points.

source:
- url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz
sha256: f9d76bc0ba1468cb77261b8d5486ee875266363310353a18aba948429aa24fda
- url: https://raw.githubusercontent.com/facebookresearch/CrypTen/main/requirements.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need this file? It repeats the information in the meta.yaml file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will make a PR once this recipe is ready, and then make the change appropriately.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this recipe is nearly ready once you remove the requirements.txt source. You can then remove one level of nesting in your url list.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but since I am not sure when the other PR would get merged, I was hoping to have the recipe available. I could then make for a stronger case for the PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the PR: facebookresearch/CrypTen#350

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to make the PR. that file is not necessary to be distributed. it is distributed as metadata along with the wheel or the conda package. Simply remove it from the recipe. You've copied the contents in the meta already.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, the commit right before that, 88f9835, did not run with the error that the requirements.txt file is not present [ref]:

  Traceback (most recent call last):
    File "<string>", line 2, in <module>
    File "<pip-setuptools-caller>", line 34, in <module>
    File "/home/conda/staged-recipes/build_artifacts/crypten_1644693818666/work/setup.py", line 20, in <module>
      with open("requirements.txt") as f:
  FileNotFoundError: [Errno 2] No such file or directory: 'requirements.txt'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh that is too bad. Yeah. this seems OK. however you aren't taking a specific tag or commit. I suspect this will be problematic in the future. You should for yourself include a cross refernece to the issue / PR you raised upstream. But this looks good now.

recipes/crypten/meta.yaml Show resolved Hide resolved
recipes/crypten/meta.yaml Outdated Show resolved Hide resolved
recipes/crypten/meta.yaml Outdated Show resolved Hide resolved
recipes/crypten/meta.yaml Outdated Show resolved Hide resolved
@hmaarrfk hmaarrfk merged commit 6b18e22 into conda-forge:main Feb 14, 2022
@sarthakpati
Copy link
Contributor Author

Awesome, thanks @hmaarrfk

@sarthakpati sarthakpati deleted the crypten branch February 14, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants