WeekFunction calculates long years incorrectly #10599
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The WeekFunction treats leap years that end on Saturday, and any year that ends on Friday or Thursday as a year with 53 weeks. However, according to Wikipedia https://en.wikipedia.org/wiki/ISO_week_date#Weeks_per_year years with 53 weeks are leap years that end on Friday and any year that ends on Thursday. I updated the logic to reflect this. I added tests to cover cases where we end up in Week 0, which is the only case where this logic is used, and verified the results match Presto Java. Differential Revision: D60427017
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D60427017 |
amitkdutta
approved these changes
Jul 30, 2024
|
This pull request has been merged in f8f538e. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
Summary: Similar to #10599, in Spark, a long year is any year ending on Thursday and any leap year ending on Friday. Since the only difference between Presto and Spark is on return type, this PR extracts the 'getWeek' function to functions/lib and changed to use 'weeknum' from external/date library for the week calculation. Pull Request resolved: #10713 Reviewed By: DanielHunte Differential Revision: D63269551 Pulled By: pedroerp fbshipit-source-id: cf8cf8b4f2a917d7a7c16a03cc8feed5f3fed5d8
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
Summary: Similar to facebookincubator#10599, in Spark, a long year is any year ending on Thursday and any leap year ending on Friday. Since the only difference between Presto and Spark is on return type, this PR extracts the 'getWeek' function to functions/lib and changed to use 'weeknum' from external/date library for the week calculation. Pull Request resolved: facebookincubator#10713 Reviewed By: DanielHunte Differential Revision: D63269551 Pulled By: pedroerp fbshipit-source-id: cf8cf8b4f2a917d7a7c16a03cc8feed5f3fed5d8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The WeekFunction treats leap years that end on Saturday, and any year that ends on Friday or
Thursday as a year with 53 weeks.
However, according to Wikipedia https://en.wikipedia.org/wiki/ISO_week_date#Weeks_per_year years
with 53 weeks are leap years that end on Friday and any year that ends on Thursday.
I updated the logic to reflect this.
I added tests to cover cases where we end up in Week 0, which is the only case where this logic is
used, and verified the results match Presto Java.
Differential Revision: D60427017