Add hour(timestamp_with_time_zone) -> int64 Presto function (#1230)

Summary: Pull Request resolved: #1230 From discussions in [github issue](prestodb/presto#7122 (comment)), it says "Extracting hour from 2016-01-01 12:00:00 <TZ> should return 12 no matter what <TZ> is put in template.". This diff implement that behavior. Reviewed By: kagamiori Differential Revision: D34944701 fbshipit-source-id: 4f9bad2de01432dce0ae158f84462a994ff5ddcc
facebookincubator · Mar 23, 2022 · a6ff2af · a6ff2af
1 parent 02c800b
commit a6ff2af
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 0 deletions.
diff --git a/velox/functions/prestosql/DateTimeFunctions.h b/velox/functions/prestosql/DateTimeFunctions.h
@@ -275,6 +275,15 @@ struct HourFunction : public InitSessionTimezone<T> {
     result = getDateTime(date).tm_hour;
     return true;
   }
+
+  FOLLY_ALWAYS_INLINE void call(
+      int64_t& result,
+      const arg_type<TimestampWithTimezone>& timestampWithTimezone) {
+    const auto milliseconds = *timestampWithTimezone.template at<0>();
+    Timestamp timestamp{milliseconds / kMillisecondsInSecond, 0UL};
+    timestamp.toTimezone(*timestampWithTimezone.template at<1>());
+    result = getDateTime(timestamp, nullptr).tm_hour;
+  }
 };
 
 template <typename T>

diff --git a/velox/functions/prestosql/registration/DateTimeFunctionsRegistration.cpp b/velox/functions/prestosql/registration/DateTimeFunctionsRegistration.cpp
@@ -46,6 +46,7 @@ void registerSimpleFunctions() {
   registerFunction<DayOfYearFunction, int64_t, Date>({"doy", "day_of_year"});
   registerFunction<HourFunction, int64_t, Timestamp>({"hour"});
   registerFunction<HourFunction, int64_t, Date>({"hour"});
+  registerFunction<HourFunction, int64_t, TimestampWithTimezone>({"hour"});
   registerFunction<MinuteFunction, int64_t, Timestamp>({"minute"});
   registerFunction<MinuteFunction, int64_t, Date>({"minute"});
   registerFunction<SecondFunction, int64_t, Timestamp>({"second"});

diff --git a/velox/functions/prestosql/tests/DateTimeFunctionsTest.cpp b/velox/functions/prestosql/tests/DateTimeFunctionsTest.cpp
@@ -339,6 +339,23 @@ TEST_F(DateTimeFunctionsTest, hour) {
   // EXPECT_EQ(21, hour(Timestamp(4000000000, 123000000)));
   EXPECT_EQ(23, hour(Timestamp(998474645, 321000000)));
   EXPECT_EQ(8, hour(Timestamp(998423705, 321000000)));
+
+  const auto hourWTZ = [&](double timestamp, std::string timeZoneName) {
+    return evaluateOnce<int64_t>(
+        "hour(from_unixtime(c0, c1))",
+        makeRowVector({
+            makeNullableFlatVector<double>({timestamp}),
+            makeNullableFlatVector<std::string>({timeZoneName}),
+        }));
+  };
+  EXPECT_EQ(20, hourWTZ(998423705, "+01:00"));
+  EXPECT_EQ(12, hourWTZ(41028, "+01:00"));
+  EXPECT_EQ(13, hourWTZ(41028, "+02:00"));
+  EXPECT_EQ(14, hourWTZ(41028, "+03:00"));
+  EXPECT_EQ(8, hourWTZ(41028, "-03:00"));
+  EXPECT_EQ(1, hourWTZ(41028, "+14:00"));
+  EXPECT_EQ(9, hourWTZ(-100, "-14:00"));
+  EXPECT_EQ(2, hourWTZ(-41028, "+14:00"));
 }
 
 TEST_F(DateTimeFunctionsTest, hourDate) {