-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: navbar search input zoom on focus #308
Conversation
Hi @hichemfantar! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
✅ Deploy Preview for infima ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There's an issue with the cla signature, waiting for a fix |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
@slorber can we merge this please? |
Thanks As far as I understand this does not really impact Docusaurus because most Docusaurus sites are using Algolia which already uses 1rem Note that sooner or later I'll deprecate Infima and merge a part of its code back into the Docusaurus theme classic as an implementation detail, so I wouldn't recommend relying too much on it for your own site styling: you'd rather create your own custom CSS for that because things we don't use in Docusaurus core are likely to be removed. |
cc @praveenn77 it's preferable if your lunr plugin did not depend on Infima classes: https://github.com/praveenn77/docusaurus-lunr-search If we create a Tailwind-based theme (which we plan to do), your plugin will not work by default because Infima won't be loaded. It is preferable that you provide your own stylesheet |
@slorber i agree that the plugin shouldn't rely on infima styles as they are prone to change but for now this a good enough fix (the plugin has 27,693 weekly downloads on npm) |
@slorber btw do you plan to publish a new release with this fix in order to fix existing websites? |
Alpha 44 is out: https://www.npmjs.com/package/infima?activeTab=versions |
closes #306
This is because inputs should have a minimum font size of 16px, anything lower will cause a zoom in on iOS.
https://stackoverflow.com/a/6394497/11334432
before:
RPReplay_Final1717247506.mp4
after:
RPReplay_Final1717247547.mp4