Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce class for reset list #233

Merged
merged 1 commit into from
Apr 14, 2022
Merged

feat: introduce class for reset list #233

merged 1 commit into from
Apr 14, 2022

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Apr 10, 2022

Similar to clean-btn, this class is designed to reset the default browser styles, but for lists this time. It is more useful in Docusaurus code base than in Infima, because it makes sense to use it on infrequent elements, such as footer lists, so as not to clutter up the HTML markup too much.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 10, 2022
@github-actions
Copy link

Dist CSS Diff

diff --git a/packages/core/dist/css/default/default.css b/packages/core/dist-branch/css/default/default.css
index 9610f30..e7de433 100644
--- a/packages/core/dist/css/default/default.css
+++ b/packages/core/dist-branch/css/default/default.css
@@ -1429,6 +1429,11 @@ hr {
   padding: 0;
 }
 
+.clean-list {
+  list-style: none;
+  padding-left: 0;
+}
+
 /* Components */
 
 /**
@@ -2320,9 +2325,7 @@ hr {
   }
 
 .footer__items {
-    list-style: none;
     margin-bottom: 0;
-    padding-left: 0;
   }
 
 /**

@github-actions
Copy link

Size Change: +100 B (0%)

Total Size: 580 kB

Filename Size Change
./packages/core/dist/css/default-dark/default-dark-rtl.css 84.3 kB +13 B (0%)
./packages/core/dist/css/default-dark/default-dark-rtl.min.css 59.2 kB +12 B (0%)
./packages/core/dist/css/default-dark/default-dark.css 84.3 kB +13 B (0%)
./packages/core/dist/css/default-dark/default-dark.min.css 59.2 kB +12 B (0%)
./packages/core/dist/css/default/default-rtl.css 82.2 kB +13 B (0%)
./packages/core/dist/css/default/default-rtl.min.css 58.1 kB +12 B (0%)
./packages/core/dist/css/default/default.css 82.2 kB +13 B (0%)
./packages/core/dist/css/default/default.min.css 58 kB +12 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/core/dist/js/alerts.js 409 B
./packages/core/dist/js/alerts.min.js 409 B
./packages/core/dist/js/button-groups.js 267 B
./packages/core/dist/js/button-groups.min.js 267 B
./packages/core/dist/js/dropdowns.js 1.01 kB
./packages/core/dist/js/dropdowns.min.js 1.01 kB
./packages/core/dist/js/menu.js 2.4 kB
./packages/core/dist/js/menu.min.js 2.4 kB
./packages/core/dist/js/navbar.js 1.08 kB
./packages/core/dist/js/navbar.min.js 1.08 kB
./packages/core/dist/js/pills.js 270 B
./packages/core/dist/js/pills.min.js 270 B
./packages/core/dist/js/radio-behavior.js 705 B
./packages/core/dist/js/radio-behavior.min.js 705 B
./packages/core/dist/js/tabs.js 267 B
./packages/core/dist/js/tabs.min.js 267 B

compressed-size-action

@netlify
Copy link

netlify bot commented Apr 10, 2022

Deploy Preview for infima ready!

Name Link
🔨 Latest commit 54ab236
🔍 Latest deploy log https://app.netlify.com/sites/infima/deploys/62534426d30bb60009f68909
😎 Deploy Preview https://deploy-preview-233--infima.netlify.app/demo
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@slorber
Copy link
Collaborator

slorber commented Apr 14, 2022

👍 fine with that

@slorber slorber merged commit 42e716b into main Apr 14, 2022
@slorber slorber deleted the lex111/clean-list branch April 14, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants