hbt/bperf: Fix time accounting in PerThreadReader #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Two major fixes here: 1. Make a copy of bperf_thread_data in seqlock'ed region and use the copy later. This makes sure the data in a sample is consistent. 2. Fix schedin_time and runtime_since_schedin, so that the runtime is accounted correctly. Before this fix, there was double accounting in some corner cases. Also add a commont to enable() to explain the check for mapping the same tid twice. I got confused myself when reading the code. Differential Revision: D63996323
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63996323 |
|
This pull request has been merged in 26a8877. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Two major fixes here:
later. This makes sure the data in a sample is consistent.
accounted correctly. Before this fix, there was double accounting in
some corner cases.
Also add a commont to enable() to explain the check for mapping the same
tid twice. I got confused myself when reading the code.
Differential Revision: D63996323