FBRelayLogger: bugfixes #250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56312126 |
Summary: * Dynolog is sending the wrong agent-type when gpu metrics are enabled. Agent-type is a constant string to identify the app that is collecting the metrics and it shouldn't change depending on the kind of metrics is sending. * Dynolog is not able to send metrics if fbrelay service is restarted, that is because the socket used for the operations is broken. This fix recreates the socket if a failure to send metrics is detected. Differential Revision: D56312126
vhenriquez
force-pushed
the
export-D56312126
branch
from
6125930 to
48ca1a4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56312126 |
|
This pull request has been merged in a5cf5ab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Dynolog is sending the wrong agent-type when gpu metrics are enabled. Agent-type is a constant string to identify the app that is collecting the metrics and it shouldn't change depending on the kind of metrics is sending.
Dynolog is not able to send metrics if fbrelay service is restarted, that is because the socket used for the operations is broken. This fix recreates the socket if a failure to send metrics is detected.
Differential Revision: D56312126