Remove unused function from dynolog/src/gpumon/Entity.h

Summary: `-Wunused-function` has identified an unused function. This diff removes it. In many cases these functions have existed for years in an unused state. Reviewed By: palmje Differential Revision: D52846495
facebookincubator · Jan 19, 2024 · d7cb4ec · d7cb4ec
1 parent 6ba84ff
commit d7cb4ec
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 28 deletions.
diff --git a/dynolog/src/gpumon/Entity.cpp b/dynolog/src/gpumon/Entity.cpp
@@ -41,6 +41,39 @@ bool Entity::operator==(const Entity& other) const {
       m_entityId == other.m_entityId;
 }
 
+int getLatestDcgmValueCB(
+    dcgm_field_entity_group_t entityGroupId,
+    dcgm_field_eid_t entityId,
+    dcgmFieldValue_v1* values,
+    int numValues,
+    void* userData) {
+  if (userData == nullptr) {
+    return DCGM_ST_BADPARAM;
+  }
+
+  cbData* data = (cbData*)userData;
+
+  /**
+   * If there's no data yet, status of the first record will be
+   * DCGM_ST_NO_DATA
+   */
+  if (values[0].status == DCGM_ST_NO_DATA) {
+    return DCGM_ST_OK;
+  } else if (values[0].status != DCGM_ST_OK) {
+    return DCGM_ST_OK;
+  }
+
+  dcgmGroupEntityPair_t entity;
+
+  entity.entityGroupId = entityGroupId;
+  entity.entityId = entityId;
+
+  data->m_values[entity].insert(
+      data->m_values[entity].end(), values, values + numValues);
+
+  return DCGM_ST_OK;
+}
+
 std::ostream& operator<<(std::ostream& os, const Entity& entity) {
   os << "EntityGroupId: " << entity.m_entityGroupId;
   os << " EntityId: " << entity.m_entityId;

diff --git a/dynolog/src/gpumon/Entity.h b/dynolog/src/gpumon/Entity.h
@@ -53,37 +53,11 @@ struct cbData {
       : m_values(values) {}
 };
 
-static int getLatestDcgmValueCB(
+int getLatestDcgmValueCB(
     dcgm_field_entity_group_t entityGroupId,
     dcgm_field_eid_t entityId,
     dcgmFieldValue_v1* values,
     int numValues,
-    void* userData) {
-  if (userData == nullptr) {
-    return DCGM_ST_BADPARAM;
-  }
-
-  cbData* data = (cbData*)userData;
-
-  /**
-   * If there's no data yet, status of the first record will be
-   * DCGM_ST_NO_DATA
-   */
-  if (values[0].status == DCGM_ST_NO_DATA) {
-    return DCGM_ST_OK;
-  } else if (values[0].status != DCGM_ST_OK) {
-    return DCGM_ST_OK;
-  }
-
-  dcgmGroupEntityPair_t entity;
-
-  entity.entityGroupId = entityGroupId;
-  entity.entityId = entityId;
-
-  data->m_values[entity].insert(
-      data->m_values[entity].end(), values, values + numValues);
-
-  return DCGM_ST_OK;
-}
+    void* userData);
 
 std::ostream& operator<<(std::ostream& os, const Entity& entity);