Skip to content

Commit

Permalink
Remove extraneous semicolon from hbt/src/ringbuffer/PerCpuRingBuffer.h (
Browse files Browse the repository at this point in the history
#188)

Summary:
Pull Request resolved: #188

Extraneous semicolons are a code smell and can mask more serious problems. `-Wextra-semi-stmt` finds them.

This diff removes an extraneous semicolon or adjusts a macro so that a semicolon is required after the macro (making it look like a standard function).

This file is drawn from a heavy-hitting list, so fixing this problem will allow *many* other files to take advantage of the safety `-Wextra-semi-stmt` offers.

This should be a low-risk diff: if it compiles, it works.

Reviewed By: meyering

Differential Revision: D51631126

fbshipit-source-id: 97cea0c1e6454a9629f834ff13e31d48079aa7cf
  • Loading branch information
r-barnes authored and facebook-github-bot committed Dec 12, 2023
1 parent b8bfacd commit 85ecd75
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion hbt/src/ringbuffer/PerCpuRingBuffer.h
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,6 @@ class PerCpuRingBuffer final {

size_t usedSizeWeak(CpuId cpu) const {
return this->getCpuRingBuffer(cpu)->usedSizeWeak();
;
}

auto getHeader() {
Expand Down

0 comments on commit 85ecd75

Please sign in to comment.