Skip to content

Commit

Permalink
Update documentation for pytorch profiler (#52)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #52

A quick update to doc for building pytorch. I had to change my original PR in pytorch to fix Linux CLA issues. Updating it here.
pytorch/pytorch#88020

Reviewed By: haowangludx

Differential Revision: D41050986

fbshipit-source-id: bcfd0bb5cc465e9447105cac285dcebb920d5c58
  • Loading branch information
briancoutinho authored and facebook-github-bot committed Nov 5, 2022
1 parent 728af70 commit 71a2d11
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion docs/pytorch_profiler.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ The following instructions walk through:
> Note that these instructions will likely change. We need recent commits in PyTorch to enable this feature. As a new PyTorch release takes place users will not need to build PyTorch from source.
Currently, we need to build PyTorch from source to obtain the latest changes that make it compatible with dynolog.
Please follow instructions in PyTorch Readme on obtaining the setup. Ensure that your checkout has the [PR#87226](https://github.com/pytorch/pytorch/pull/87226/) (use `git log` to check).
Please follow the instructions in [PyTorch README](https://github.com/pytorch/pytorch/blob/master/README.md) on obtaining the setup. Ensure that your checkout has the [PR#88020](https://github.com/pytorch/pytorch/pull/88020/) (use `git log` to check).

Before building, also pull in latest changes from Kineto dependency using:
```bash
Expand All @@ -28,6 +28,13 @@ Before building, also pull in latest changes from Kineto dependency using:
```
The minimum version needed is one containing [PR#653](https://github.com/pytorch/kineto/pull/653/), commit a36e47e6d080abd62ca26dd2a007c8f4cd0bd600

Lastly, disable the `USE_LITE_INTERPRETER_PROFILER` setting. One way to do this is change the option in `pytorch/CMakeLists.txt`.
```
if(USE_LITE_INTERPRETER_PROFILER)
- string(APPEND CMAKE_CXX_FLAGS " -DEDGE_PROFILER_USE_KINETO")
+ # string(APPEND CMAKE_CXX_FLAGS " -DEDGE_PROFILER_USE_KINETO")
endif()
```
You are all set to build and install PyTorch.
```bash
python setup.py install
Expand Down

0 comments on commit 71a2d11

Please sign in to comment.