Skip to content

Commit

Permalink
Remove unused exception parameter from files inc dynolog/src/rpc/Simp…
Browse files Browse the repository at this point in the history
…leJsonServerInl.h (#204)

Summary:
Pull Request resolved: #204

`-Wunused-exception-parameter` has identified an unused exception parameter. This diff removes it.

This:
```
try {
    ...
} catch (exception& e) {
    // no use of e
}
```
should instead be written as
```
} catch (exception&) {
```

If the code compiles, this is safe to land.

Reviewed By: dmm-fb

Differential Revision: D51977808

fbshipit-source-id: 615639c2db7d63fbac33e3a3a4317b48dbc869d1
  • Loading branch information
r-barnes authored and facebook-github-bot committed Jan 3, 2024
1 parent b39deb1 commit 29e39de
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion dynolog/src/rpc/SimpleJsonServerInl.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ nlohmann::json toJson(const std::string& message) {
}
try {
result = json::parse(message);
} catch (json::parse_error& ex) {
} catch (json::parse_error&) {
LOG(ERROR) << "Error parsing message = " << message;
return result;
}
Expand Down

0 comments on commit 29e39de

Please sign in to comment.