Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ttp dev doc #44

Merged
merged 27 commits into from
Aug 31, 2023
Merged

Add ttp dev doc #44

merged 27 commits into from
Aug 31, 2023

Conversation

VVX7
Copy link
Contributor

@VVX7 VVX7 commented Aug 27, 2023

Proposed Changes

Add documentation for developing new TTPs. Docs is roughly based on what I've seen in the examples TTPs. Looking forward to feedback on this.

Related Issue(s)

n.a

Testing

Spellcheck :)

Documentation

n/a

Screenshots/GIFs (optional)

n.a

Checklist

  • [ x ] Curated your commit(s) so they are legible and easy to read and understand.
  • [ x ] 🚀

Copy link
Contributor

@l50 l50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an AMAZING contribution, thank you so much for this!

I've provided some suggestions that should appease pre-commit (all standards based).

docs/ttp-dev.md Outdated Show resolved Hide resolved
docs/ttp-dev.md Outdated Show resolved Hide resolved
docs/ttp-dev.md Outdated Show resolved Hide resolved
docs/ttp-dev.md Outdated Show resolved Hide resolved
docs/ttp-dev.md Outdated Show resolved Hide resolved
docs/ttp-dev.md Outdated Show resolved Hide resolved
docs/ttp-dev.md Outdated Show resolved Hide resolved
docs/ttp-dev.md Outdated Show resolved Hide resolved
docs/ttp-dev.md Outdated Show resolved Hide resolved
docs/ttp-dev.md Outdated Show resolved Hide resolved
@l50 l50 requested a review from cedowens August 27, 2023 22:50
VVX7 and others added 23 commits August 27, 2023 19:45
Co-authored-by: Jayson Grace <[email protected]>
Co-authored-by: Jayson Grace <[email protected]>
Co-authored-by: Jayson Grace <[email protected]>
Co-authored-by: Jayson Grace <[email protected]>
Co-authored-by: Jayson Grace <[email protected]>
Co-authored-by: Jayson Grace <[email protected]>
Co-authored-by: Jayson Grace <[email protected]>
Co-authored-by: Jayson Grace <[email protected]>
Co-authored-by: Jayson Grace <[email protected]>
Co-authored-by: Jayson Grace <[email protected]>
Co-authored-by: Jayson Grace <[email protected]>
Co-authored-by: Jayson Grace <[email protected]>
Co-authored-by: Jayson Grace <[email protected]>
Co-authored-by: Jayson Grace <[email protected]>
Co-authored-by: Jayson Grace <[email protected]>
Co-authored-by: Jayson Grace <[email protected]>
Co-authored-by: Jayson Grace <[email protected]>
Co-authored-by: Jayson Grace <[email protected]>
Co-authored-by: Jayson Grace <[email protected]>
Co-authored-by: Jayson Grace <[email protected]>
Co-authored-by: Jayson Grace <[email protected]>
Co-authored-by: Jayson Grace <[email protected]>
Co-authored-by: Jayson Grace <[email protected]>
@VVX7
Copy link
Contributor Author

VVX7 commented Aug 28, 2023

blah, sorry for pr spam..

Copy link
Contributor

@sw8y sw8y Aug 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My goodness this was SOOOO helpful. Thank you for making this!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! and thank you for the new TTP!

@l50 l50 enabled auto-merge (squash) August 31, 2023 02:54
@l50 l50 self-requested a review August 31, 2023 02:54
Copy link
Contributor

@l50 l50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@l50 l50 merged commit f07facc into facebookincubator:main Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants