Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move get-running-processes out of macOS specific directory #36

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Move get-running-processes out of macOS specific directory #36

merged 2 commits into from
Aug 25, 2023

Conversation

l50
Copy link
Contributor

@l50 l50 commented Aug 23, 2023

Proposed Changes

  • Moved get-running-processes TTP out of macOS directory since it can be used on *nix systems as well.

Related Issue(s)

N/A

Testing

Ran TTP to confirm that it worked.

Documentation

N/A

Screenshots/GIFs (optional)

N/A

Checklist

  • Ran mage runprecommit locally and fixed any issues that arose.
  • Curated your commit(s) so they are legible and easy to read and understand.
  • 🚀

@l50
Move get-running-processes out of macOS specific directory
997d3a5 
- TTP can be used on *nix systems, not just macOS
@l50 l50 requested a review from cedowens August 23, 2023 22:20
@VVX7
Copy link
Contributor

VVX7 commented Aug 23, 2023

Looks good, ty!

@l50 l50 merged commit 7bf8286 into main Aug 25, 2023
@l50 l50 deleted the minor-refactor branch August 25, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d3sch41n d3sch41n d3sch41n approved these changes

@CrimsonK1ng CrimsonK1ng Awaiting requested review from CrimsonK1ng CrimsonK1ng is a code owner

@cedowens cedowens Awaiting requested review from cedowens cedowens is a code owner

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@l50 @VVX7 @d3sch41n @facebook-github-bot