Skip to content
This repository has been archived by the owner on Dec 15, 2020. It is now read-only.

Commit

Permalink
Fix chromium bug (frozen chaperone)
Browse files Browse the repository at this point in the history
Summary:
## Motivation (required)

Same issue as [this](toji/chrome-webvr-issues#64 (comment)). Basically chaperone gets frozen and nothing else gets rendered. Also got this warning message in the console: `GL ERROR :GL_INVALID_OPERATION : glFramebufferTexture2D`.

The same issue was solved by adding `alpha: true` when constructing the `WebGLRenderer`.

## Test Plan (required)

I've only got a Vive so needs to be tested on other non-openVR platforms.
Closes #161

Reviewed By: mikearmstrong001

Differential Revision: D4963586

Pulled By: andrewimm

fbshipit-source-id: f62864b
  • Loading branch information
fmnxl authored and facebook-github-bot committed Apr 28, 2017
1 parent f98932c commit c3238d8
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions OVRUI/src/Player/Player.js
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,10 @@ export default class Player {

// Set up the Three.js basics: renderer, camera, controls
const antialias = options.hasOwnProperty('antialias') ? options.antialias : true;
const alpha = options.hasOwnProperty('canvasAlpha') ? options.canvasAlpha : true;
const renderer = new THREE.WebGLRenderer({
antialias: antialias,
alpha: alpha,
});
renderer.setPixelRatio(pixelRatio);
renderer.setSize(width, height);
Expand Down

0 comments on commit c3238d8

Please sign in to comment.