This repository has been archived by the owner on Apr 19, 2023. It is now read-only.
OSX doesn't seem to have MSG_NOSIGNAL #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimpurbrick
added a commit
that referenced
this pull request
Jun 15, 2015
OSX doesn't seem to have MSG_NOSIGNAL
sdwilsh
added a commit
to facebook/buck
that referenced
this pull request
Jun 15, 2015
Summary: This picks up facebookarchive/nailgun#57 and facebookarchive/nailgun#58 to actually close #262. Test Plan: CI
denji
added a commit
to closure-gun/nailgun
that referenced
this pull request
Jul 13, 2015
denji
added a commit
to closure-gun/nailgun
that referenced
this pull request
Jul 21, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the comment on #57 OSX doesn't seem to have MSG_NOSIGNAL. I think this should get it building again, although I don't have an Apple (or Windows) dev environment available. Could setsocketopt SO_NOSIGPIPE as an alternative, if OSX compatibbility is a goal for this project.